[feat]: add slow back animation prop for better ux#165
Open
Aberratio wants to merge 3 commits into
Open
Conversation
TouqeerH
reviewed
May 24, 2024
Comment on lines
+114
to
+119
| if (backAnimationType === 'standard') { | ||
| return physics.animateBack; | ||
| } else if (backAnimationType === 'slow') { | ||
| return physics.animateSlow; | ||
| } | ||
| return physics.none; |
There was a problem hiding this comment.
This could be more readable.
if (backAnimationType === 'standard') return physics.animateBack;
if (backAnimationType === 'slow') return physics.animateSlow;
return physics.none;
Owner
|
I think a much better solution to this is exposing the spring configuration for the back animation instead. Letting the user fine tune exactly how they want the back animation to behave. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation of the card's return (
animateBack) is very fast and makes a very "aggressive" movement of passing to the other side.In order to make it possible to use a slower or even remove it altogether, I propose to introduce
backAnimationTypeprops that defaults tostandardand keeps the existing operation.On the other hand, it will be possible to use this function and:
slow, which will delay theanimateBackeffect.none, which will completely remove the effect of the return animation.